[MPlayer-dev-eng] Re: [PATCH] small encoder segv fix

[Alban Bedel]

Hi D Richard Felker III,

on Tue, 19 Aug 2003 19:21:34 -0400 you wrote:

> On Tue, Aug 19, 2003 at 08:52:14PM +0100, Alex Sisson wrote:
> >  --- D Richard Felker III <dalias at aerifal.cx> wrote: >
> > On Mon, Aug 18, 2003 at 10:33:09PM +0100, Alex
> > > Sisson wrote:
> > > > Hi guys,
> > > > 
> > > > if you do mencoder foo.wav -oac somecodec  
> > > mencoder
> > > > will segfault.
> > > > so this is just a simple fix for that.
> > > 
> > > mencoder is a *movie* encoder, so it's not supposed
> > > to work with
> > > audio-only files.
> > it's also not meant to segfault.
> > 
> > > That would be kinda silly anyway
> > > -- putting mp3
> > > audio inside an avi file with no video.
> > yes
> > 
> > > If you want
> > > to fix this bug,
> > > make mencoder print an error message and quit if
> > > there's no video
> > > stream.
> > thats sort of what it does. the function fails and the
> > calling function (whatever that is) prints an error
> > about loading the video so i didn't think another was
> > necessary. then it quits.
> 
> Hmm, maybe it's ok then. Anyone else have thoughts on this?
The check could (should?) be done in mencoder instead.
Anyway this segfault must be fixed, so you can also apply as is.
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.