[MPlayer-dev-eng] [PATCH] Latest CVS OGG Tremor and Theora

Martin Drab drab at kepler.fjfi.cvut.cz
Fri Aug 15 18:58:06 CEST 2003


On 15 Aug 2003, David Kuehling wrote:

> > Hi,
> 
> >> > Hi,
> >> >
> >> > here is a patch to let MPlayer (tested on MPlayer-20030814) compile
> >> with > latest CVS OGG Theora and Tremor. It just reacts on a slightly
> >> diffrent > API when using Tremor instead of Vorbis for decoding and
> >> reacts on > Theora API change. This patch has no influence on
> >> compiling MPlayer > without Tremor (i.e. it works with Vorbis too).
> 
> Did you check my patch posted here around 20030811?  I created a patch
> for newer theora API already months ago, it's just not yet accepted.
> Any changes beyond what I did (except for Tremor)?

I'll take a look at it and try to merge our patches together. Probably 
yours solution to Theora is better, so I'll combine it with my Tremor 
patch and send it. There would probably be a problem in applying them, 
when they were separate (Tremor and Theora), because they apply to the 
same files.
 
> > I can't see the theora lib version check in configure, so it will fail
> > for all users with non-latest theora libs.  So either it should be
> > fixed, or theora support should be disabled by default.
> 
> Hmm.  What a chaos, two patches for the same thing.  My recent patch
> does these configure checks, so any other reason for not applying it?
> 
> David
 
Martin




More information about the MPlayer-dev-eng mailing list