[MPlayer-dev-eng] [PATCH] dvb input update

[Nico]

Arpi wrote:

>Hi,
>
>  
>
>>here's the dvb patch updated with documentation in HTML.
>>Diego, can you please take a look at and correct  the docs?.
>>
>>I also fixed a small bug in the dvb channel parsing code.
>>
>>I hope to see this patch applied :)
>>    
>>
>
>Maybe, after some changes.
>
>Please, split it to at least 3 parts:
>- DOCS/
>- menu/input changes (i dont know that code, so i wont apply it, maybe Albeu
>  will)
>
ok

>- demuxer changes (i'll check and commit)
>
there no demuxer patch in my post, it was in a previous message posted 
some days ago

>
>About the demuxer part of your patch:
>- too much cosmetics
>- i see some progress in removing namespace mess (lots of global vars)
>  but:
>- ther are new, even worse 'namespace polluting' entries, like the very very
>  confusing DVB-specific demux_start(), open_fe(), get_tuner_type()...
>  please prefix all exported (non-static) variabne and function name with
>  dvb_ or dvbin_. but it's better make them static when possible, i doubt
>  you really need so much global funcs and vars. think of g2, where globals
>  are not allowed at all!
>  
>
ok

>if you fix these, i'll commit the patch (the demuxer part).
>
>
>A'rpi / Astral & ESP-team
>
>--
>Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu
>
>_______________________________________________
>MPlayer-dev-eng mailing list
>MPlayer-dev-eng at mplayerhq.hu
>http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>
>  
>
Thanks,
    Nico