[MPlayer-dev-eng] [PATCH] configurable BINDIR and MANDIR; silencing compiler warnings, continued

[Arpi]

Hi,

> Second, I managed to silence most compiler warnings for now (patch
> attached). Note that this reverses my last patch to
> libmpcodecs/vd_ffmpeg.c, because it was wrong. This patch changes the
> definition of draw_slice to be consistent in all places and makes
> appropriate changes wherever it's used. Small fix to
nice (and 10l to me :()

> postprocess_template.c silences the "SCALED_CPY redefined" warning. Next
Michael?

> is a fix of dvdcss_open definitions (makes them consistent everywhere).
hmm
are you sur ethese fixes are the good fixes (especially the off_t* -> off_t)
? then i'll submit them to livdvdcss devel team.

> Now this one:
> mplayer.c:1261: warning: assignment makes pointer from integer without a cast
> mplayer.c:1262: warning: assignment makes pointer from integer without a cast
> is very interesting, because the same code
> mplayer.c:
> [...]
> sh_video->vfilter=vf_open_filter(NULL,"vo",video_out);
> sh_video->vfilter=append_filters(sh_video->vfilter);
> [...]
> compiles without warning in all other places

this warning pops up when you have missing/bad declaration for
vf_open_filter() so the compiler things it returns int, but you want to
store the return value in void* (sh_video->vfilter).

include "vf.h" should help here

> The following one
> open.c:494: warning: assignment discards qualifiers from pointer target type
i've never seen such warning msg

> libmpdemux/open.c:
> [...]
> int dvd_parse_chapter_range(struct config *conf, const char *range){
>   char *s, *t;
>   conf; /* prevent warning from GCC */
>   s = range;
>   dvd_chapter = 1;
> [...]
> I think should be fixed by making a copy of range instead of assigning
> the pointer.
hmm
or remove 'const' ?

> This one:
> vo_xv.c:484: warning: assignment makes pointer from integer without a cast
> is curious, too, because:
> libvo/vo_xv.c:
> [...]
> static XvImage* xvimage[NUM_BUFFERS];
> [...]
>    xvimage[foo] = XvShmCreateImage(mDisplay, xv_port, xv_format, 0,
> image_width, image_height, &Shmi
> [...]
> XvShmCreateImage does return (XvImage*). I checked it three times.

but is the needed .h file (containing XvShmCreateImage() decl) included there?

> loader/win32.c:

leave the loader stuff now, mayeb mail them to Kabi, if he agree i'll commit


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu