[MPlayer-dev-eng] Re: [PATCH] error checking for lavc stats_file writing

[Michael Niedermayer]

Hi

On Sunday 01 September 2002 12:32, Eric Lammerts wrote:
> On Sun, 1 Sep 2002, Michael Niedermayer wrote:
> > On Saturday 31 August 2002 13:40, Eric Lammerts wrote:
> > > Hi,
> > > this patch adds error checking to lavc's stats_file writing.
> >
> > yes, and then it calls exit(); imho this is worse then not checking at
> > all
>
> If you don't check, you end up with a corrupted stats file with no
> indication that something bad happened (i.e., exit status == 0). How
> is this better?
imho put_image() should not call exit(), just imaging fprintf() would call 
exit internally, it would be annoying too ...
the solution would be to set some global flag, print an error message in 
put_image() and check this flag somewhere in mencoder.c and exit there

[...]

Michael