[MPlayer-dev-eng] [PATCH] hide cursor on terminal

[Arpi]

Hi,

> Hey. I would just commit this directly, but I'm not too familiar with
> getch2.c so I'd like to run it by everyone first. This patch hides the
> cursor when getch2 is enabled, which is needed when using the bes on
> some cards, since the annoying flashing cursor appears over top of the
> overlay. The old TOOLS/mpconsole script I wrote works around this, but
> since it's mostly obsolete already I'd like to go ahead and make it
> entirely obsolete. If no one objects I'll commit this patch soon.

i'm against it.

1. getch2 isn't the right place to hide cursor unconditionaly.
   what if i like to see the cursor while i'm playing in a window or an
   external decoder card or another monitor? at least make it optional, and
   disabled by default
2. if you're using libtermcap functions, at least add #ifdef, as termcap is
   optional and is detected by configure. there are platforms with no
   termcap at all.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu