[MPlayer-dev-eng] Re: [PATCH] Read extended (>2GB) AVI files

[D Richard Felker III]

On Fri, May 10, 2002 at 11:10:39AM +0200, Felix Buenemann wrote:
> On Thursday 09 May 2002 19:52, Wolfram Gloger wrote:
> > >yes, but your conversions from int to long are bad, as long is 64bot on
> > >64bit cpus like alpha, while it's 32bit on 32bit cpus liek x86
> >
> > I am well aware of that, thank you very much.  Please point out where
> > exactly such a "bad conversion" is in the patch, and I will certainly
> > fix it.  However, there is not a single conversion from an int to a
> > long variable, just the necessary ones to off_t, for compatibility
> > with the demuxer_... interface, which is (correctly!) 64bit if
> > --enable-large-files is used.  Also some casts to unsigned if a value
> > that could be >2GB is used.
> just looked, you do typecasts to unsigned long eg. in printfs.

printf'ing a type like off_t is not valid (since there is no format
character for it), so unfortunately these type of casts are probably
necessary. However, I expect the cast should actually be to long long
if we don't want big numbers to get truncated...

Rich