[MPlayer-dev-eng] Re: [Mplayer-cvslog] CVS: main/libmpcodecs vd_qtrpza.c,1.1,1.2

[Roberto Togni]

On 2002.03.06 16:25 Arpi of Ize wrote:
> Update of /cvsroot/mplayer/main/libmpcodecs
> In directory mplayer:/var/tmp.root/cvs-serv28832
> 
> Modified Files:
> 	vd_qtrpza.c
> Log Message:
> optim :)
> 
> Index: vd_qtrpza.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpcodecs/vd_qtrpza.c,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- vd_qtrpza.c	2 Mar 2002 22:08:19 -0000	1.1
> +++ vd_qtrpza.c	6 Mar 2002 15:25:10 -0000	1.2
> @@ -60,7 +60,7 @@
>      }
> 
>      qt_decode_rpza(data, len, mpi->planes[0], sh->disp_w, sh->disp_h,
> -	((mpi->imgfmt&255)+7)/8);
> +	mpi->bpp/8);
I think it can give problems with BGR15 modes: 15/8 = 1, while BGR15 
takes 2 bytes.
It should be (mpi->bpp+7)/8. Probably adding 1 would be enough, but 7 
is worst case.

> 
>      return mpi;
>  }
> 
Ciao,
  Roberto