[MPlayer-dev-eng] [PATCH] get rid of 'implicit definition' in DS_Filter.c

Felix Buenemann atmosfear at users.sourceforge.net
Wed Jul 10 05:11:36 CEST 2002


On Tuesday 09 July 2002 18:06, Sylvain Petreolle wrote:
> all is in title : loader/dshow/DS_Filter.c
IMHO the patch is bad:
 - it doesn't create module.h (learn how to use diff correctly)
 - in dshow/DS_Filter.c you include registry.h instead of module.h
 - module.h has no protection against multiple inclusion
-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________



More information about the MPlayer-dev-eng mailing list