[MPlayer-dev-eng] Re: [PATCH] Development (Was: Clean up demuxers)

[Daniel Egger]

Am Die, 2002-02-26 um 01.30 schrieb Arpi:

> > I see. Didn't realise that it can be negative also. Why's that BTW?
> why not? RTFS.

I didn't stumble over anything that made it negative so far. And I would
really like to RTFS if it was readable (read: not so buttugly in big
parts)

> what's the problem with this? it is not my code, anyway it looks ok for me.

Spaghetti code. Easy to get it wrong, hard to read.

> > So you have troubles using development tools? Say it so and I might be
> > able to live with that. Otherwise this is simply FUD.
 
> why?

Because it's not the slightest problem to merge changes if you're used
to CVS. Even better with bitkeeper.
 
> you seems to be a tipical 'doesn't matter if it won't work or slower,
> or breaks compatibility, but the source looks nicer' programmer (not coder).

Sure. Guess what: The main reason for rewritting the select spaghetti
code was that the demuxer actually showed in up in the upper half of
my profiles which made me curious. Now while it isn't the optimal
solution as you've pointed out it's already a lot faster and what's more
important: CLEAN.

I will probably do a bit more there since I might need the stuff for a
future project. I'll toss in the patches, what you do with them is your
problem.

-- 
Servus,
       Daniel