[MPlayer-dev-eng] [PATCH] mga_vid memleak fix

[D Richard Felker III]

On Sun, Feb 03, 2002 at 09:19:19PM +0100, Attila Kinali wrote:
> On Sun, 3 Feb 2002 13:50:24 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > well see, that's not enough -- mplayer's text output gets trashed
> > while it's playing even, as does any other text that gets printed,
> > e.g. if you switch to another console to irc or something while the
> > movie is playing.
> 
> Hmm.. never had such effects. What is your kernel config and
> which resolution do you have on the console ?

kernel version is 2.4.12-ac3, but it's happened ever since 2.2. my
config looks identical to yours, except that i include the fastfont
option on the kernel command line, which causes matroxfb to use an
alternate method of drawing text which should be faster -- and which
the author of matroxfb recommended i try after i had problems with an
old version of matroxfb.

anyway, my console is usually 1024x768, but the same happens at
640x480 and perhaps other sizes. whether the corruption takes place or
not seems to be more dependent on the actual dimensions of the movie.
my guess is....the reason it doesn't always happen is that some movie
sizes don't come out to an integral number of pages, so the end of the
last page of video memory (which contains the font) never gets touched
when playing those movies. on the other hand, nice standard sizes like
320x240 or 640x480 seem to always trash the font. make sense?

> > fyi, i only have 8 megs, and it's more than enough for mga_vid even
> > with the font-preserving hack i put in. but, it probably would make
> > the most sense to make the amount of memory skipped for font space a
> > module loadtime option, so that users can just configure it in
> > modules.conf. sound good?
> 
> Juup, that sound far better.
> Also the "save memory" could be done as an option

should i write a patch and send it?

rich