[MPlayer-dev-eng] [PATCH] mplayer fails to link with newer binutils

seru seru at gmx.net
Sun Dec 22 14:15:54 CET 2002


El dom, 22 de dic de 2002, a las 01:52:30 +0100, seru dijo:
> El dom, 22 de dic de 2002, a las 11:38:54 +0100, Soeren Sonnenburg dijo:
> > On Sun, 2002-12-22 at 12:04, Arpi wrote:
> > > Hi,
> > [...]
> > > > If one compiles for MMX it helps to remove the #include "tabinit.c" in
> > > > sr1.c. However I could not test compilation *without* MMX...
> > > > --disable-MMX{,2} didn't do anything...
> > > 
> > > --disable-mmx
> > > 
> > > (have you ever try ./configure --help ????)
> > 
> > sure.
> > 
> > I did make distclean ; ./configure --disable-mmx --disable-mmx2 ; make
> > and it did still compile with the #include line removed.
> > BUT it was compiling the *_MMX stuff.
> I think it's supposed to (not sure) http://www.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/mp3lib/Makefile.diff?r1=1.24&r2=1.25
> Anyways, I've included a patch, tell me if it works for you.
> +#define real float
>  
> -static long decwin [544];
> +real decwin [512+32];

Might seem a little ugly and stupid, but I did it for sake of consistency :)
'real' is a macro which is defined as 'float' in the whole mp3lib dir:
fuego:/usr/src/MPlayer-CVS/main/mp3lib # grep -r real .|grep ugly
./dct64_MMX.c:#define real float /* ugly - but only way */
./decode_i586.c:#define real float /* ugly - but only way */
./dct64_3dnow.c:#define real float /* ugly - but only way */
./decode_MMX.c:#define real float /* ugly - but only way */
./dct64_k7.c:#define real float /* ugly - but only way */

How about s/real/float in the whole mp3lib dir? 





More information about the MPlayer-dev-eng mailing list