[MPlayer-dev-eng] Re: [PATCH] Some minor patches (for RTSP/RTP streaming)

[Arpi]

Hi,

> -if(stream_dump_type==5){
> +if(stream_dump_type==5 && stream->fd >= 0){
>     unsigned char buf[4096];

i've reversed this change and teh one for -cache too

there are many stream formats - including DVD - which doesn't have
steram->fd but other (usually in stream->priv) handlers to teh stream data.
this patch broke dvd cache and others too.

you should find a cleaner way, ideas:
- add a new field to steram struct like dummy_steram si we can taht it isn't
  a real, readable (using stream_read()) stream
- set stream->type to something and check its value instead of fd<0
- route your raw steram theough our stream layer --> preferred way but maybe
  hard/impossible to implement with live.com lib design


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu