[MPlayer-dev-eng] [PATCH] mplayer compilation with icc

[Arpi]

Hi,

>  - -O3 is the highest -O flag, -O4 changed to -O3 for icc
ok
>  - -DUSING_ICC added to CFLAGS to allow ICC specific code
ok
>  - -g flag seems to hate me.  (mplayer behaved like a gcc
>      2.96 copy using icc -g)  -g removed from Makefiles
ok
>  - won't always link functions that are static inline,
>      static inline removed in some places.
bad!
>  - -W flag has nothing to do with warnings, removed from Makefiles
ok
>  - certain -f flags don't exist, they are removed from Makefiles
sometimes bad
i remember places where it was required to work with some gcc versions
>  - 3dnow opts don't compile in liba52, ifdef'd out for icc
ok
>  - strangely worded statement in libao2, reworded.
>      (possibly wrong. FIXME)
yes it's a big FIXME:

ao_plugin_data.len=(int)(((double)ao_plugin_data.len)*=pl_format.sz_mult);

this line has no much sense...
i bet that '*=' in the middle should be just '*'
anyone familiar with that code could comment on this?
i remember there were ugly rounding problems so i wouldn't just fix that
without permission...

>  - functions inside of functions are invalid in icc.  replaced
>      with #define's. (possibly wrong. FIXME.)
where?

>  - libmpcodecs/native/RTjpegN.c, something weird about icc
>      not liking MMX code there.  #ifdef'd out for icc.
ok
>  - if __GNUC__ is not defined, gcc's byteswap.h does not define
>      all the needed byteswap functions.  #define __GNUC__ 3 added
>      to libmpdvdkit/bswap.h
ok
>  - inb and outb not found at link, defined as inline asm for icc.
ok, but strange
>  - under icc, __int8, __int16, __int32, __int64 are already typedef'd.
hmm

anyway you should use #ifndef USING_ICC instead of #if !defined(USING_ICC)
it's cleaner...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu