[MPlayer-dev-eng] configure: cleanups + bugfix for MT

[pl]

On Thu, Oct 11, 2001 at 02:08:43PM +0200, Arpi wrote:
> Hi,
> 
> > A minor patch to configure:
> >  - if test ... ; replaced by if [ test ...] ; since it seems the
> >    preferred test construction
> >  - [ ! -z "$foo" ] ; replaced by [ "$foo" ]
> 
> please re-make it for 'if test' method, it seems to be more portable.
[...]

Changed:
[ $foo = "" ]   => test -z "$foo"
[ $foo != "" ]  => test "$foo"
[ $foo ... ]    => test "$foo" ...
'yes' or "yes"	=> yes
'no' or "no"	=> no

test X -a Y	=> test X && test Y
test X -o Y	=> test X || test Y
(it appears more portable according to autoconf manual)

Bugfix for building MT version (it is in the enclosed patch):
AFAIK for Linux, too, the CFLAG -D_THREAD_SAFE should be added (same
thing as -D_REENTRANT  - check in /usr/include/feature.h).

I guess it should be safe to always add this flag for any other OS but
tests should be carried out.


This patch should break nothing... well... it does not here :)

--
Regards,
  pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.diff.gz
Type: application/octet-stream
Size: 8992 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20011011/91aa2308/attachment.obj>