[MPlayer-dev-eng] Another likely bug: libac3/imdct.c line 585 or so, etc...

[Felix Buenemann]

On Monday, 26. November 2001 12:44, you wrote:
> Where imdct.c is downmixing to stereo post idct, this code appears
> for case "7" (3/2 format):
>
[snip code]
>
> I'm pretty sure there's a mistake here in the last line: that *center++
> should be *delay1_center++.  That's fits the logic, and currently its
> inconsistent with the left channel handling.
>
> Similar code appears for other cases - each occurrence of center is wrong.
>
> I suspect that this code isn't run often as it needs an ac3 frame where
> some channels are using one 512 point idct, others 2 256 point ones.
>
> Do you agree?  I'll fix in my surround patch unless anyone thinks my
> understanding is wrong...
could you send a sepearte patch for this? I would like to check if it fixes 
strange high noise with some dvd content (eg The 6th Sense Trailer).

And is this code always used or only by non-asm optmized code?
>
> Steve
>
-- 
Best Regards,
	Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________