[MPlayer-cygwin] [BUG] Cygwin compile failure in libfaad2/output.c

[Diego Biurrun]

Diego Biurrun writes:
 > Cygwin fails to compile for me ATM:
 > 
 > make[1]: Entering directory `/home/diego/mplayer/dev/libfaad2'
 > cc -c -I. -I../libvo/ -I../../libvo -g -O4 -march=k6-2 -mcpu=k6-2 -pipe 
 > -ffast-math -fomit-frame-pointer -D_LARGEFILE_SOURCE 
 > -D_FILE_OFFSET_BITS=64 -D__CYGWIN__ -o output.o output.c
 > output.c: In function `dither_output':
 > output.c:203: warning: integer constant is too large for "long" type
 > output.c:203: warning: integer constant is too large for "long" type
 > output.c:208: warning: integer constant is too large for "long" type
 > output.c:208: warning: integer constant is too large for "long" type
 > output.c:214: warning: integer constant is too large for "long" type
 > output.c:214: warning: integer constant is too large for "long" type
 > {standard input}: Assembler messages:
 > {standard input}:1009: Error: value of -131 too large for field of 1 
 > bytes at 1698
 > {standard input}:1125: Error: value of -133 too large for field of 1 
 > bytes at 1995
 > make[1]: *** [output.o] Error 1
 > make[1]: Leaving directory `/home/diego/mplayer/dev/libfaad2'
 > make: *** [libfaad2/libfaad2.a] Error 2
 > 
 > I'm running latest Cygwin on W2K SP4, compiler and assembler:
 > 
 > gcc (GCC) 3.3.1 (cygming special)
 > GNU assembler 2.14.90 20030901
 > 
 > I built with
 > 
 > ./configure --disable-tv --disable-ossaudio --disable-mencoder 
 > --disable-edl --disable-inet6 --disable-flac --disable-tga 
 > --with-codecsdir=/lib/codecs
 > 
 > Any ideas/fixes?

OK, Sascha told me on IRC to change line 46 of libfaad2/output.c to

  #define ROUND64(x) (doubletmp = (x) + Dither.Add + (int64_t)0x001FFFFD80000000LL, *(int64_t*)(&doubletmp) - (int64_t)0x433FFFFD80000000LL)

changing L to LL.  Now compilation goes a little further, but fails again:

make -C libfaad2
make[1]: Entering directory `/home/diego/mplayer/dev/libfaad2'
cc -c -I. -I../libvo/ -I../../libvo -g -O4 -march=k6-2 -mcpu=k6-2 -pipe -ffast-m
ath -fomit-frame-pointer -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D__CYGWIN__
   -o output.o output.c
{standard input}: Assembler messages:
{standard input}:1009: Error: value of -131 too large for field of 1 bytes at 1698
{standard input}:1125: Error: value of -133 too large for field of 1 bytes at 1995
make[1]: *** [output.o] Error 1
make[1]: Leaving directory `/home/diego/mplayer/dev/libfaad2'
make: *** [libfaad2/libfaad2.a] Error 2


Any more clues?

Diego