[MPlayer-advusers] reproducible crash in r23784

[Dominik 'Rathann' Mierzejewski]

On Tuesday, 17 July 2007 at 17:22, Reimar Döffinger wrote:
> Hello,
> On Mon, Jul 16, 2007 at 08:43:15PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 16 July 2007 at 20:11, Reimar Doeffinger wrote:
> > > Hello,
> > > On Mon, Jul 16, 2007 at 06:45:17PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > On Sunday, 15 July 2007 at 19:57, Reimar Döffinger wrote:
> > > > > Hello,
> > > > > On Sun, Jul 15, 2007 at 06:13:26PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > > > Sample is in our sample collection:
> > > > > > http://samples.mplayerhq.hu/sub/NeroMP4/unsupported-embedded-subs-2.mp4
> > > > > > 
> > > > > > This happens whenever I press 'j' during playback.
> > > > > 
> > > > > Fixed, though it might break demuxers that do not fill sub->s_streams
> > > > > correctly (though I do not know of any demuxers where that is still the
> > > > > case).
> > > > 
> > > > Fixed the crash, yes, but now the subtitles behave weird. If I don't specify
> > > > -sid 2, it's impossible to switch to the subtitles on using 'j'.
> > > 
> > > With that file (I think it has only one subtitle?) or with some other
> > > file?
> > 
> > With that file. It does have just one subtitle. I haven't tested others.
> 
> Not caused by that patch, problem is our sid numbering is a real mess.
> Attached patch lets you select the subtitle, though it will also allow
> you to select -sid 0 and -sid 1 which do not actually exist.

Indeed it works exactly as you said. Thanks.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan