[MPlayer-advusers] [BUG] regression when playing a DVD after r18429

Diego Biurrun diego at biurrun.de
Wed Aug 29 01:37:46 CEST 2007


On Wed, Aug 29, 2007 at 12:30:18AM +0200, Nico Sabbi wrote:
> Nico Sabbi wrote:
>
>> Diego Biurrun wrote:
>>
>>> If that last solution works in both cases (and does not introduce
>>> regressions) then I guess it is preferable.
>>
>> the patch attached will set the movie_aspect with the value reported
>> by the stream reader if the information is available, but the I have to 
>> admin that the solution (in mplayer.c) is quite ugly:
>> first of all relying on a global such as movie_aspect (in mplayer.c and 
>> libmpcodecs/vd.c) simply sucks; secondly movie_aspect should be reset to 
>> its original value after the completion of the current playtree item.
>> I don't have much time to dedicate to this issue, so anyone feel free to 
>> enhance the patch in a more appropriate manner.
>
> oops, patch without cosmetics

I guess you should post it to dev-eng, it will likely be overlooked
here...

Diego



More information about the MPlayer-advusers mailing list