[FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

Michael Niedermayer michael at niedermayer.cc
Mon Jul 28 17:01:53 EEST 2025


Hi Marvin

On Fri, Jul 11, 2025 at 05:34:48PM +0200, Marvin Scholz wrote:
> 
> 
> On 25 Jun 2025, at 23:39, Tristan Matthews via ffmpeg-devel wrote:
> 
> > On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt <andreas.rheinhardt at outlook.com> wrote:
> >
> > Tristan Matthews via ffmpeg-devel:
> >
> > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt andreas.rheinhardt at outlook.com wrote:
> >
> > Patch attached.
> >
> > LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried make fate on a few different machines and didn't hit that.
> >
> > Best,
> > Tristan
> >
> >
> > I used (Clang) ASAN. Presumably Zhao Zhili (who first reported the stack
> > buffer overflow) did so, too.
> >
> > - Andreas
> >
> >
> > It'd be good to merge either this or Zhao Zhili's patch to get checkasm back to being ASAN clean.
> >
> > Best,
> > Tristan
> 
> If there are no objections, I would like to merge this patch soon.

there where no objections, this is still broken, i just run into it
again.

please apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250728/dde17e0a/attachment.sig>


More information about the ffmpeg-devel mailing list