[FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

[James Almer]

On 2/27/2025 7:53 PM, Vittorio Giovara wrote:
> On Thu, Feb 27, 2025 at 11:47 PM <epirat07 at gmail.com> wrote:
> 
>> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
>>
>>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>>> ---
>>>   doc/developer.texi | 11 +++++------
>>>   1 file changed, 5 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/doc/developer.texi b/doc/developer.texi
>>> index a1bfe180c9b..6a753f99da6 100644
>>> --- a/doc/developer.texi
>>> +++ b/doc/developer.texi
>>> @@ -179,18 +179,17 @@ int fields = ilace ? 2 : 1;
>>>   @end example
>>>
>>>   @item
>>> -No braces around single-line blocks:
>>> +No braces around single-line blocks, unless they are followed by an
>> else (to keep future patches cleaner)
>>>
>>
>> I agree with this, however people in the past pointed it out when new code
>> did this, IIRC.
>>
>> So if we merge this, people should stop flagging this in reviews, else its
>> frustrating
>> for new contributors following the documentation and then getting
>> contradicting reviews.
> 
> 
> would loooove a format defining script with a prehook that formats your
> patches before sending <3

That can be done automatically as one of the many jobs CI runs once we 
move to forgejo/gitlab. Same with every other check in patcheck.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250227/b662fd0b/attachment.sig>