[FFmpeg-devel] [PATCH] ffv1dec: fix threaded decode failures

[Lynne]

On 05/02/2025 17:26, Lynne wrote:
> On 05/02/2025 15:51, James Almer wrote:
>> On 2/5/2025 11:47 AM, Lynne wrote:
>>> Fixes 7187eadf8c0f0c640f1d23811c55fad0cba60aa5
>>>
>>> The issue is that while avctx->pix_fmt is synchronized between
>>> threads, f->pix_fmt was not.
>>>
>>> Fixes fate-vsynth1-ffv1-2pass10 with THREADS=2.
>>
>> Can confirm "make fate-vsynth{1,2,3,_lena} THREADS=2" (as well as 
>> higher thread count) passes with this patch.
>>
>>> ---
>>>   libavcodec/ffv1dec.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c
>>> index fcf3d525ac..0284845503 100644
>>> --- a/libavcodec/ffv1dec.c
>>> +++ b/libavcodec/ffv1dec.c
>>> @@ -1114,6 +1114,7 @@ static int update_thread_context(AVCodecContext 
>>> *dst, const AVCodecContext *src)
>>>       fdst->plane_count         = fsrc->plane_count;
>>>       fdst->ac                  = fsrc->ac;
>>>       fdst->colorspace          = fsrc->colorspace;
>>> +    fdst->pix_fmt             = fsrc->pix_fmt;
>>>       fdst->ec                  = fsrc->ec;
>>>       fdst->intra               = fsrc->intra;
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 
> Thanks.
> I'll push this soon unless there are objections.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Pushed, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250206/d773302c/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250206/d773302c/attachment.sig>