[FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

[Michael Niedermayer]

On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote:
> Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit :
> > Fixes: CID1559855 Unchecked return value from library
> 
> This is again very misleading. Logging an error (that most people won't even 
> see) is not fixing a bug. Either this is not a bug, and this patch can't be 
> fixing a non-bug, or this is a bug, and this patch is hiding it behind a fake 
> fix.

As written in the commit message, the patch would fix CID1559855.
It doesnt claim anything else

[...]


> 
> So IMO, 5c3d2177e7be7dde69a83b1b394f57976c164c84 should be reverted instead.

if thats preferred, i have nothing against doing that instead

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240525/befee349/attachment.sig>