[FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

[Michael Niedermayer]

On Thu, May 23, 2024 at 11:03:37AM +0200, Anton Khirnov wrote:
> Share the code between encoding and decoding. Instead of checking every
> stream's options dictionary (which is also used for other purposes),
> track all used options in a dedicated dictionary.
> ---
>  fftools/cmdutils.c        | 17 ++++++++----
>  fftools/cmdutils.h        |  4 ++-
>  fftools/ffmpeg.c          | 49 ++++++++++++++++++++++++++++++++++
>  fftools/ffmpeg.h          |  3 ++-
>  fftools/ffmpeg_demux.c    | 50 ++++++++---------------------------
>  fftools/ffmpeg_mux.c      |  1 +
>  fftools/ffmpeg_mux.h      |  3 +++
>  fftools/ffmpeg_mux_init.c | 55 +++++----------------------------------
>  fftools/ffmpeg_opt.c      | 18 -------------
>  fftools/ffplay.c          |  2 +-
>  fftools/ffprobe.c         |  2 +-
>  11 files changed, 89 insertions(+), 115 deletions(-)

breaks https://samples.ffmpeg.org/image-samples/exr/sub.0030.exr

./ffmpeg -layer RenderLayer.Color -gamma 2.2  -i sub.0030.exr -bitexact  /tmp/test-color2.2.jpg

Input #0, exr_pipe, from 'sub.0030.exr':
  Duration: N/A, bitrate: N/A
  Stream #0:0: Video: exr, gbrapf32le, 960x540 [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 25 tbn
[in#0/exr_pipe @ 0x55c06b88b7c0] Codec AVOption gamma (set gamma) is not a decoding option.
Error opening input file sub.0030.exr.
Error opening input files: Invalid argument

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240524/209fd101/attachment.sig>