[FFmpeg-devel] [PATCH] lavc/vp9: set update_map to 0 when segmentation.enabled is 0

[Ronald S. Bultje]

Hi,

On Wed, May 22, 2024 at 1:28 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:

> On Wed, May 22, 2024 at 7:16 PM Lynne via ffmpeg-devel
> <ffmpeg-devel at ffmpeg.org> wrote:
> > I'd hate to apply fixes with no information in shared code. This can get
> > removed with no information about what relies on it.
>
> Changing 5 different hwaccel modules to avoid one line here seems
> rather silly, doesn't it?
> We can add a comment, if that helps.
>

Comment is a good idea, I think Lynne is right there's a risk we
accidentally remove it.

Generally, I'd like to see more hwaccel fate coverage, e.g. a vaapi (or
whatever) fate machine that runs relevant tests using hw decoder instead of
sw decoder. That would protect against the same risk.

Ronald