[FFmpeg-devel] [PATCH v4 1/5] lavc/vp9dsp: R-V V mc avg

[Rémi Denis-Courmont]

Le tiistaina 21. toukokuuta 2024, 18.36.02 EEST flow gg a écrit :
> > Please put commas between operands.
> 
> Okay
> 
> > This should probably be ff_avg_vp9 or something slightly more specific.
> 
> Is it necessary here?

It works because VP9 is the odd one out doing this. All non-static symbols in 
libavcodec are in the same namespace.

> Many macros in the C file are copied from MIPS, where
> it is called ff_avg4_msa. Here, it has been simply changed to ff_avg4_rvv.

AArch64 uses ff_vp9_avg which seems a lot saner.


-- 
Rémi Denis-Courmont
http://www.remlab.net/