[FFmpeg-devel] [PATCH] avcodec/h264_slice: Remove dead sps check

Michael Niedermayer michael at niedermayer.cc
Mon May 13 23:09:32 EEST 2024


On Mon, May 13, 2024 at 09:04:34AM +0300, Rémi Denis-Courmont wrote:
> 
> 
> Le 6 mai 2024 04:23:07 GMT+03:00, Michael Niedermayer <michael at niedermayer.cc> a écrit :
> >Fixes: CID1439574 Dereference after null check
> 
> If SPS is guaranteed to be non-NULL, there should probably be an assertion to document it, and it should be *before* that alleged dereference (which is not visible in the patch context).

why ?

I mean why would sps require an assert*(sps) but the overwhelming majority
of pointers, we just dereference without assert before them ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240513/0546b347/attachment.sig>


More information about the ffmpeg-devel mailing list