[FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000dec: remove ST=3 case

Tomas Härdin git at haerdin.se
Mon May 13 11:59:01 EEST 2024


mån 2024-05-13 klockan 10:51 +0200 skrev Tomas Härdin:
> fre 2024-05-10 klockan 16:07 +0200 skrev Michael Niedermayer:
> > Fixes: CID1460979 Logically dead code
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/jpeg2000dec.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c
> > index 28bf6be2fef..135537b52fb 100644
> > --- a/libavcodec/jpeg2000dec.c
> > +++ b/libavcodec/jpeg2000dec.c
> > @@ -835,9 +835,6 @@ static int get_tlm(Jpeg2000DecoderContext *s,
> > int
> > n)
> >          case 2:
> >              bytestream2_get_be16(&s->g);
> >              break;
> > -        case 3:
> > -            bytestream2_get_be32(&s->g);
> > -            break;
> 
> I will also point out get_tlm() doesn't actually do anything other
> than
> advance the bytestream. We could just as well advance by Ltlm

Correction: it does validate that the TLM marker is correctly
formatted, so that's something at least

/Tomas


More information about the ffmpeg-devel mailing list