[FFmpeg-devel] [PATCH 3/3] lavc/speedhqdec: Set AV_PICTURE_TYPE_I

[Andreas Rheinhardt]

Tomas Härdin:
> ons 2024-05-08 klockan 17:06 -0300 skrev James Almer:
>> On 5/8/2024 5:01 PM, Marton Balint wrote:
>>>
>>>
>>> On Wed, 8 May 2024, Tomas Härdin wrote:
>>>
>>>>
>>>>
>>>
>>> What suprises me is that pict_type and the keyframe flag is not set
>>> already for decoding codecs with AV_CODEC_PROP_INTRA_ONLY flag. Is
>>> this 
>>> intentional or just nobody had the time to set it up to work
>>> automatically?
>>
>> For audio it's not always the case (See MLP/TrueHD). For video it
>> might 
>> with intra-only codecs, but at least with non intra-only codecs, an I
>> frame is not necessarily a keyframe (See AV1).
> 
> Yes, IDR frames exist. We're talking about intra-only though.
> 
> I'll push this on Monday if there are no objections. We can adds some
> logic for always setting key_frame and/or pict_type in the appropriate
> place for intra-only codecs as a separate patch. That would allow us to
> simplify all intra-only codecs as well, which would be nice
> 

Already done: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/327065.html

- Andreas