[FFmpeg-devel] [PATCH 1/3] riscv: add Zvbb vector bit manipulation extension

[Rémi Denis-Courmont]

Le 7 mai 2024 23:34:14 GMT+03:00, "Martin Storsjö" <martin at martin.st> a écrit :
>On Tue, 7 May 2024, Rémi Denis-Courmont wrote:
>
>> ---
>> Makefile                  | 2 +-
>> configure                 | 3 +++
>> doc/APIchanges            | 3 +++
>> ffbuild/arch.mak          | 1 +
>> libavutil/cpu.h           | 1 +
>> libavutil/tests/cpu.c     | 1 +
>> tests/checkasm/checkasm.c | 1 +
>> 7 files changed, 11 insertions(+), 1 deletion(-)
>> 
>> diff --git a/libavutil/tests/cpu.c b/libavutil/tests/cpu.c
>> index d91bfeab5c..10e620963b 100644
>> --- a/libavutil/tests/cpu.c
>> +++ b/libavutil/tests/cpu.c
>> @@ -94,6 +94,7 @@ static const struct {
>>     { AV_CPU_FLAG_RVV_F32,   "zve32f"     },
>>     { AV_CPU_FLAG_RVV_I64,   "zve64x"     },
>>     { AV_CPU_FLAG_RVV_F64,   "zve64d"     },
>> +    { AV_CPU_FLAG_RV_ZVBB,   "zvbb"      },
>> #endif
>>     { 0 }
>> };
>
>Doesn't this test require you to add this extension to the list in libavutil/cpu.c as well?

TBH, I don't see the point of this stuff. These options look like cargo cult to me.