[FFmpeg-devel] [PATCH 4/5] avcodec/dovi_rpuenc: Initialize bl_compat_id

[Andreas Rheinhardt]

Michael Niedermayer:
> Fixes: CID1596607 Uninitialized scalar variable
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/dovi_rpuenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/dovi_rpuenc.c b/libavcodec/dovi_rpuenc.c
> index 7e0292533bd..c5e452957b5 100644
> --- a/libavcodec/dovi_rpuenc.c
> +++ b/libavcodec/dovi_rpuenc.c
> @@ -57,7 +57,7 @@ int ff_dovi_configure(DOVIContext *s, AVCodecContext *avctx)
>      AVDOVIDecoderConfigurationRecord *cfg;
>      const AVDOVIRpuDataHeader *hdr = NULL;
>      const AVFrameSideData *sd;
> -    int dv_profile, dv_level, bl_compat_id;
> +    int dv_profile, dv_level, bl_compat_id = -1;
>      size_t cfg_size;
>      uint64_t pps;
>  

This is unnecessary, as the dv_profile switch is exhaustive (i.e. the
default case is never taken); but if you do this, then you can also
remove the other "bl_compat_id = -1" assignments (which conveys that
everything is treated as invalid unless we found it to have a valid
compatibility id).

- Andreas