[FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data

[Michael Niedermayer]

Hi

On Thu, May 02, 2024 at 11:23:13PM +0200, Marton Balint wrote:
[...]

> surely some users depend on it behaving in a certain
> way...

who ?
I dont think you should assume something without evidence
especially for framecrc, which isnt that usefull except for
testing the output is changed vs identical. This patch (or
a variation of it) improves this very usecase

Also whats your oppinion Marton ?
should we test side data or not test side data. In teh tests in
FFmpeg (FATE) ?
And framecrc is what tests the produced AVPackets

I think james replied to the rest already

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240503/72fe9c9f/attachment.sig>