[FFmpeg-devel] [PATCH 2/2] avcodec/amd: fix pict_type, match it with amf & ffmpeg. add sps pps when frame->keyframe

[Dmitrii Ovchinnikov]

The idea itself looks good to me, but the patch is corrupted.

Regarding the patch:
1)
>>// Keyframe overrides previous assignment.
It might be better instead of:
setting the frame type -> if key frame then overwrite
to do:
check for key frame and if it's not, set other PICTURE_TYPE
to avoid unnecessary overwriting
(use AV_FRAME_FLAG_KEY instead of deprecated key_frame,
as already noted under the second patch)
2) The patch includes logic for AV_CODEC_ID_H264 and AV_CODEC_ID_HEVC,
but not for AV_CODEC_ID_AV1.( FORCE_INSERT_SEQUENCE_HEADER
 AMF_VIDEO_ENCODER_AV1_FORCE_FRAME_TYPE )