[FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24
Anton Khirnov
anton at khirnov.net
Sun Nov 26 12:29:54 EET 2023
Quoting James Almer (2023-11-24 22:03:29)
> On 11/24/2023 6:01 PM, Michael Niedermayer wrote:
> > On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote:
> >> Should simplify asm implementations, and prevent UB on at least win64.
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >> libavcodec/ac3dsp.c | 2 +-
> >> libavcodec/ac3dsp.h | 2 +-
> >> libavcodec/arm/ac3dsp_init_arm.c | 2 +-
> >> libavcodec/mips/ac3dsp_mips.c | 2 +-
> >> libavcodec/x86/ac3dsp_init.c | 4 ++--
> >> 5 files changed, 6 insertions(+), 6 deletions(-)
> >
> > In file included from src/libavcodec/mips/ac3dsp_mips.c:57:0:
> > src/libavcodec/ac3dsp.h:56:62: error: unknown type name ‘size_t’; did you mean ‘__ssize_t’?
> > void (*float_to_fixed24)(int32_t *dst, const float *src, size_t len);
> > ^~~~~~
> > __ssize_t
> > src/ffbuild/common.mak:81: recipe for target 'libavcodec/mips/ac3dsp_mips.o' failed
> > make: *** [libavcodec/mips/ac3dsp_mips.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > mips FAIL
>
> Do you know where is size_t defined for this target? stddef.h?
size_t should _always_ be defined in stddef.h, as per C99 7.17.2
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list