[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

[David Bohman]

On Fri, Nov 24, 2023 at 8:09 PM Zhao Zhili <quinkblack at foxmail.com> wrote:
>
>
>
> > On Nov 25, 2023, at 05:32, David Bohman <debohman at gmail.com> wrote:
> >
> > On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili <quinkblack at foxmail.com> wrote:
> >>
> >>> On Nov 24, 2023, at 23:40, David Bohman <debohman at gmail.com> wrote:
> >>>
> >>> This is to fix a build failure on macOS < 10.13.
> >>>
> >> It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build failure.
> >> I prefer use compat_keys, so it can be build on macOS < 10.13, get the key at runtime
> >> and run on macOS >= 10.13.
> >
> > Correct, kVTCompressionPropertyKey_EncoderID appeared in 10.13,
> > according to the Apple Developer documentation.
> >
> > Are you going to do your own fix?
>
> Could you test the following patch? Thanks.
>
> https://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317366.html

Looks good.