[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

David Bohman debohman at gmail.com
Fri Nov 24 17:40:43 EET 2023


This is to fix a build failure on macOS < 10.13.

This is a build failure in release 6.1. The issue also exists at the
top of the master branch, and the patch applies there.
---
 libavcodec/videotoolboxenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index b0e827d14a..b72eb470fd 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -1172,7 +1172,6 @@ static int vtenc_create_encoder(AVCodecContext   *avctx,
             return AVERROR_EXTERNAL;
         }
     }
-#endif

     // Dump the init encoder
     {
@@ -1201,6 +1200,7 @@ static int vtenc_create_encoder(AVCodecContext   *avctx,
         if (encoderID != NULL)
             CFRelease(encoderID);
     }
+#endif

     if (avctx->flags & AV_CODEC_FLAG_QSCALE && !vtenc_qscale_enabled()) {
         av_log(avctx, AV_LOG_ERROR, "Error: -q:v qscale not available
for encoder. Use -b:v bitrate instead.\n");
-- 
2.43.0


More information about the ffmpeg-devel mailing list