[FFmpeg-devel] [PATCH] Fixed nvenc release dump

[Timo Rothenpieler]

I don't quite understand the commit message.
It should start with "avcodec/nvenc:" and then state what it's changing 
and why.

On 24/11/2023 08:04, GOOR, Jean-Noel wrote:
> Signed-off-by: GOOR, Jean-Noël <jn.goor at evs.com>
> ---
>   libavcodec/nvenc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
> index 3c68ed3930..1f8c7e8c0e 100644
> --- a/libavcodec/nvenc.c
> +++ b/libavcodec/nvenc.c
> @@ -1860,7 +1860,7 @@ av_cold int ff_nvenc_encode_close(AVCodecContext *avctx)
>       av_fifo_freep2(&ctx->unused_surface_queue);
>   
>       if (ctx->frame_data_array) {
> -        for (i = 0; i < ctx->nb_surfaces; i++)
> +       for (i = 0; i < ctx->frame_data_array_nb; i++)

Wrong indentation.

The change itself looks correct to me on first glance.
Did you find this via a leak checker?

>               av_buffer_unref(&ctx->frame_data_array[i].frame_opaque_ref);
>           av_freep(&ctx->frame_data_array);
>       }