[FFmpeg-devel] [PATCH] checkasm/flacdsp: fix ls/rs/ms tests

Rémi Denis-Courmont remi at remlab.net
Mon Nov 13 21:23:47 EET 2023


decorrelate_ls, _rs and _ms are decorrelate[1], [2] and [3] respectively.
The code ended up testing indep ([0]) as twice, ms never, and misnaming
the other two.
---
 tests/checkasm/flacdsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/checkasm/flacdsp.c b/tests/checkasm/flacdsp.c
index ef93df8c81..51a0e0060b 100644
--- a/tests/checkasm/flacdsp.c
+++ b/tests/checkasm/flacdsp.c
@@ -78,7 +78,7 @@ void checkasm_check_flacdsp(void)
     for (i = 0; i < 2; i++) {
         ff_flacdsp_init(&h, fmts[i].fmt, 2);
         for (j = 0; j < 3; j++)
-            if (check_func(h.decorrelate[j], "flac_decorrelate_%s_%d", names[j], fmts[i].bits))
+            if (check_func(h.decorrelate[j + 1], "flac_decorrelate_%s_%d", names[j], fmts[i].bits))
                 check_decorrelate(&ref_dst, ref_src, &new_dst, new_src, 2, fmts[i].bits);
         for (j = 2; j <= MAX_CHANNELS; j += 2) {
             ff_flacdsp_init(&h, fmts[i].fmt, j);
-- 
2.42.0



More information about the ffmpeg-devel mailing list