[FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

[Ronald S. Bultje]

Hi,

On Wed, Nov 8, 2023 at 10:55 AM Ronald S. Bultje <rsbultje at gmail.com> wrote:

> Hi Jianhui,
>
> On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J <
> jianhui.j.dai-at-intel.com at ffmpeg.org> wrote:
>
>> The smaller delta patch to export the variable:
>> https://patchwork.ffmpeg.org/project/ffmpeg/patch/DM6PR11MB268186349E600824E1577DFDB1A8A@DM6PR11MB2681.namprd11.prod.outlook.com/
>> Personally, I prefer to limit the static data only in vp8.c.
>>
>
> Understood. It's going to be a dice-roll either way, and since I'm the
> maintainer, I get to pick :-). I prefer continuing with what we have in
> this version, but I'll leave it open for the majority opinion to overrule
> me for a few days before we merge this.
>

Actually, I realize that sounds quite rude, so let me elaborate: I prefer
external data tables (in a separate source file from the rest of the code)
because they tend to be big and clunky and you can't really change them
anyway. They are essentially binary blob in numerical form. We use external
data tables in quite a few parts of ffmpeg and I've grown accustomed to
that design. For now, for old codecs where nothing much changes over time,
I prefer to keep it as it is. Small diffs means easy to trace back when
stuff breaks, as a general rule.

But I admit that all this is personal preference. There's nothing wrong
with a different approach, it's just that: different. Let's agree on a
color (green!) and move on to shiny new objects.

Ronald