[FFmpeg-devel] [PATCH 08/24] fftools/ffmpeg_filter: remove an unnecessary sub2video_push_ref() call

[Anton Khirnov]

It only seems to produce duplicate frames.
---
 fftools/ffmpeg_filter.c               | 3 ---
 tests/ref/fate/sub2video_basic        | 3 ---
 tests/ref/fate/sub2video_time_limited | 1 -
 3 files changed, 7 deletions(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index c738fc3397..d48974581b 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -2266,9 +2266,6 @@ void ifilter_sub2video_heartbeat(InputFilter *ifilter, int64_t pts, AVRational t
            or if we need to initialize the system, update the
            overlayed subpicture and its start/end times */
         sub2video_update(ifp, pts2 + 1, NULL);
-
-    if (av_buffersrc_get_nb_failed_requests(ifp->filter))
-        sub2video_push_ref(ifp, pts2);
 }
 
 int ifilter_sub2video(InputFilter *ifilter, const AVFrame *frame)
diff --git a/tests/ref/fate/sub2video_basic b/tests/ref/fate/sub2video_basic
index a6eb1a34ea..314b7a07dd 100644
--- a/tests/ref/fate/sub2video_basic
+++ b/tests/ref/fate/sub2video_basic
@@ -12,7 +12,6 @@
 0,     183357,     183357,        0,  1382400, 0x00000000
 0,     183433,     183433,        0,  1382400, 0x85547fd1
 0,     185799,     185799,        0,  1382400, 0x00000000
-0,     185909,     185909,        0,  1382400, 0x00000000
 0,     185910,     185910,        0,  1382400, 0xb6a8f181
 0,     188606,     188606,        0,  1382400, 0x00000000
 0,     188663,     188663,        0,  1382400, 0xb64d1a2c
@@ -59,7 +58,6 @@
 0,     296776,     296776,        0,  1382400, 0x00000000
 0,     300049,     300049,        0,  1382400, 0xaf08b10d
 0,     301949,     301949,        0,  1382400, 0x00000000
-0,     302034,     302034,        0,  1382400, 0x00000000
 0,     302035,     302035,        0,  1382400, 0x853a9d93
 0,     303559,     303559,        0,  1382400, 0x00000000
 0,     304203,     304203,        0,  1382400, 0x7491a87d
@@ -76,7 +74,6 @@
 0,     326403,     326403,        0,  1382400, 0x00000000
 0,     327193,     327193,        0,  1382400, 0x35b85f2e
 0,     328285,     328285,        0,  1382400, 0x00000000
-0,     328360,     328360,        0,  1382400, 0x00000000
 0,     328361,     328361,        0,  1382400, 0x83f103e5
 0,     329885,     329885,        0,  1382400, 0x00000000
 0,     329946,     329946,        0,  1382400, 0xbc1ca9b3
diff --git a/tests/ref/fate/sub2video_time_limited b/tests/ref/fate/sub2video_time_limited
index c7d48d639f..0634d5857e 100644
--- a/tests/ref/fate/sub2video_time_limited
+++ b/tests/ref/fate/sub2video_time_limited
@@ -5,4 +5,3 @@
 #sar 0: 0/1
 0,       6072,       6072,        0,  8294400, 0x00000000
 0,       6072,       6072,        0,  8294400, 0xa87c518f
-0,      36101,      36101,        0,  8294400, 0xa87c518f
-- 
2.42.0