[FFmpeg-devel] [PATCH] Extract av_hls_codec_attr

[Zhao Zhili]

> 在 2023年11月3日，下午1:21，Romain Beauxis <romain.beauxis at gmail.com> 写道：
> 
> Le mar. 31 oct. 2023 à 11:47, Zhao Zhili <quinkblack at foxmail.com> a écrit :
>> 
>> 
>>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Romain Beauxis
>>> Sent: 2023年10月30日 9:06
>>> To: ffmpeg-devel at ffmpeg.org
>>> Cc: Romain Beauxis <toots at rastageeks.org>
>>> Subject: [FFmpeg-devel] [PATCH] Extract av_hls_codec_attr
>>> 
>>> The logic for extracting HLS codec attribute strings is very useful and
>>> can be re-used in many different situations when working with HLS
>>> streams using libavcodec/libavformat.
>>> 
>>> This patch extracts the function's code and places it into a publicly
>>> available function.
>> 
>> I don't think the implementation is complete enough to be exported as
>> an API. And the ad-hoc API needs some design too.
> 
> I am not in a position to dispute this assessment but I would say it
> could be a "build it and they will come" kind of situation (or chicken
> and egg too).

Maybe it’s fine for internal implementation, but dangerous for API.

> 
>>> 
>>> ---
>>> libavcodec/Makefile  |   2 +
>>> libavcodec/hls.c     | 105 +++++++++++++++++++++++++++++++++++++++++++
>>> libavcodec/hls.h     |  42 +++++++++++++++++
>>> libavformat/hlsenc.c |  83 +++-------------------------------
>>> 4 files changed, 155 insertions(+), 77 deletions(-)
>>> create mode 100644 libavcodec/hls.c
>>> create mode 100644 libavcodec/hls.h
>>> 
>> 
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-dev