[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: #define TARGET_CPU_ARM64 to 0 if not provided by the SDK

Timo Rothenpieler timo at rothenpieler.org
Sat May 15 15:11:07 EEST 2021


On 15.05.2021 11:45, Zane van Iperen wrote:
> Fixes build failure on older SDKs without it.
> 
> Fixes #9242
> 
> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
> ---
>   libavcodec/videotoolboxenc.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> NB: This is untested, I do not have a Mac to try it on.
> 
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 58239e0ab9..3d3677362a 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -50,6 +50,11 @@ enum { kCVPixelFormatType_420YpCbCr10BiPlanarFullRange = 'xf20' };
>   enum { kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange = 'x420' };
>   #endif
>   
> +/* Older SDKs don't have this, make sure we can actually compile we're using one. */

Second half of that sentence is missing a word or has too many.

> +#ifndef TARGET_CPU_ARM64
> +#   define TARGET_CPU_ARM64 0
> +#endif
> +
>   typedef OSStatus (*getParameterSetAtIndex)(CMFormatDescriptionRef videoDesc,
>                                              size_t parameterSetIndex,
>                                              const uint8_t **parameterSetPointerOut,
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4494 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210515/b5160abd/attachment.bin>


More information about the ffmpeg-devel mailing list