[FFmpeg-devel] [PATCH 12/12] lavf/framecrcenc: do not hash side data

[Michael Niedermayer]

On Sun, Apr 25, 2021 at 09:03:20AM +0200, Anton Khirnov wrote:
> There are no guarantees that all side data types have the same
> representation on all platforms.

> @@ -65,63 +51,6 @@ static int framecrc_write_packet(struct AVFormatContext *s, AVPacket *pkt)
>               pkt->stream_index, pkt->dts, pkt->pts, pkt->duration, pkt->size, crc);
>      if (pkt->flags != AV_PKT_FLAG_KEY)
>          av_strlcatf(buf, sizeof(buf), ", F=0x%0X", pkt->flags);
> -    if (pkt->side_data_elems) {
> -        int i;
> -        av_strlcatf(buf, sizeof(buf), ", S=%d", pkt->side_data_elems);

The number and type of the side data elements should not be affected
by the problem described.
Maybe we could leave that. Bugs could manifest as the absence or addition
of side data, seeing that in framecrc_write_packet() output may be usefull

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210510/e1fbb93a/attachment.sig>