[FFmpeg-devel] [PATCH] lavfi/buffersink: cast to uint64_t before shifting.

[Nicolas George]

James Almer (12020-09-08):
> It's a macro designed for this specific purpose. Figured it would be
> proper, and we're using them in other parts of the code to shift the
> values by more than 32 bits, like you're doing here. But yes, i should
> have said could, not should.
> 
> I don't consider it less readable, and it's just as long as using a
> cast, but of course it's up to you.

I honestly do not know what good these macros do, except for sparking
bikeshedding discussions like this one. I can only assume they were
meant for barely-complying compilers where the cast would produce an
annoying false-positive warning.

Anyway, I pushed like this.

Thanks for your input.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200909/48c7c76a/attachment.sig>