[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: Fix leak of options when parsing options fails

[Paul B Mahol]

lgtm

On 2/28/20, Andreas Rheinhardt <andreas.rheinhardt at gmail.com> wrote:
> Fixes #8094.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  fftools/ffmpeg_opt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 12d44886ee..3bf90bd20c 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -3278,6 +3278,7 @@ static int open_files(OptionGroupList *l, const char
> *inout,
>          if (ret < 0) {
>              av_log(NULL, AV_LOG_ERROR, "Error parsing options for %s file "
>                     "%s.\n", inout, g->arg);
> +            uninit_options(&o);
>              return ret;
>          }
>
> --
> 2.20.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".