[FFmpeg-devel] [PATCH 2/2] avcodec/cdtoons: Remove superfluous ;

Fu, Linjie linjie.fu at intel.com
Thu Feb 27 08:15:26 EET 2020


> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: Thursday, February 27, 2020 13:34
> To: ffmpeg-devel at ffmpeg.org
> Cc: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/cdtoons: Remove
> superfluous ;
> 
> The second ; in a double ;; is actually a null statement. It triggers
> the typical declaration-after-statement compiler-warnings if it occurs
> in the middle of several declarations (like here).
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavcodec/cdtoons.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c
> index d5dce6351f..13f9a60f0f 100644
> --- a/libavcodec/cdtoons.c
> +++ b/libavcodec/cdtoons.c
> @@ -61,7 +61,7 @@ static int cdtoons_render_sprite(AVCodecContext
> *avctx, const uint8_t *data,
>  {
>      CDToonsContext *c = avctx->priv_data;
>      const uint8_t *next_line = data;
> -    const uint8_t *end = data + data_size;;
> +    const uint8_t *end = data + data_size;
>      uint16_t line_size;
>      uint8_t *dest;
>      int skip = 0, to_skip, x;
> --

lgtm, same issue exists in vf_cas.c maybe could be fixed in one commit.

libavfilter/vf_cas.c:61:        const int w1 = w - 1;;
libavfilter/vf_cas.c:128:        const int w1 = w - 1;;

- Linjie


More information about the ffmpeg-devel mailing list