[FFmpeg-devel] [PATCH v4 20/21] h264_metadata_bsf: Refactor the filter function into smaller parts

[Andreas Rheinhardt]

Mark Thompson:
> +    // If an AUD is present, it must be the first NAL unit.
> +    if (au->units[0].type == H264_NAL_AUD) {
> +        if (ctx->aud == REMOVE)
> +            ff_cbs_delete_unit(ctx->cbc, au, 0);
> +    } else {
> +        if (ctx->aud == INSERT)
> +            h264_metadata_insert_aud(bsf, au);

Why is this unchecked?

- Andreas

PS: More detailled review comes later.