[FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

[Paul B Mahol]

On 2/23/20, James Almer <jamrial at gmail.com> wrote:
> On 2/23/2020 9:33 AM, Paul B Mahol wrote:
>> lgtm
>
> No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent
> any of these functions from running on old CPUs.

this is about building.

>
> It would help actually knowing what kind of failure is the user getting.
>
>>
>> On 2/23/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
>>> From: Parker Ernest <@>
>>>
>>> commit fc6a5883d6af8cae0e96af84dda0ad74b360a084 breaks build on
>>> x86_64 CPUs which do not have SSSE3, e.g. AMD Phenom-II
>>>
>>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>>> ---
>>>  libswscale/x86/yuv2rgb.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libswscale/x86/yuv2rgb.c b/libswscale/x86/yuv2rgb.c
>>> index c12e88cbb5..4791e5b93a 100644
>>> --- a/libswscale/x86/yuv2rgb.c
>>> +++ b/libswscale/x86/yuv2rgb.c
>>> @@ -83,6 +83,7 @@ av_cold SwsFunc ff_yuv2rgb_init_x86(SwsContext *c)
>>>  #if HAVE_X86ASM
>>>      int cpu_flags = av_get_cpu_flags();
>>>
>>> +#if HAVE_SSSE3
>>>      if (EXTERNAL_SSSE3(cpu_flags)) {
>>>          switch (c->dstFormat) {
>>>          case AV_PIX_FMT_RGB32:
>>> @@ -111,6 +112,7 @@ av_cold SwsFunc ff_yuv2rgb_init_x86(SwsContext *c)
>>>              return yuv420_rgb15_ssse3;
>>>          }
>>>      }
>>> +#endif
>>>
>>>      if (EXTERNAL_MMXEXT(cpu_flags)) {
>>>          switch (c->dstFormat) {
>>> --
>>> 2.17.1
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".