[FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

Paul B Mahol onemda at gmail.com
Sat Feb 15 15:15:20 EET 2020


On 2/15/20, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> Am Sa., 15. Feb. 2020 um 09:45 Uhr schrieb Paul B Mahol <onemda at gmail.com>:
>>
>> On 2/15/20, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> > Am Fr., 14. Feb. 2020 um 21:25 Uhr schrieb Paul B Mahol
>> > <onemda at gmail.com>:
>> >
>> >> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
>> >> index 621a87cf34..48d0e91370 100644
>> >> --- a/libavcodec/codec_desc.c
>> >> +++ b/libavcodec/codec_desc.c
>> >> @@ -1871,8 +1871,8 @@ static const AVCodecDescriptor
>> >> codec_descriptors[] =
>> >> {
>> >>      {
>> >>          .id        = AV_CODEC_ID_PCM_ZORK,
>> >>          .type      = AVMEDIA_TYPE_AUDIO,
>> >> -        .name      = "pcm_zork",
>> >> -        .long_name = NULL_IF_CONFIG_SMALL("PCM Zork"),
>> >> +        .name      = "adpcm_zork",
>> >> +        .long_name = NULL_IF_CONFIG_SMALL("ADPCM Zork"),
>> >
>> > Didn't we consider this an ABI break in the past?
>>
>> I can remove pcm_zork, deprecate PCM_ZORK codec id, and add new
>> ADPCM_ZORK codec id which this decoder will use.
>
> No strong opinion here, perhaps others want to comment...

Actually it is more logical so it is done.

>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list