[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

[Paul B Mahol]

On 2/14/20, Fu, Linjie <linjie.fu at intel.com> wrote:
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Fu,
>> Linjie
>> Sent: Tuesday, February 11, 2020 20:58
>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel at ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale
>> to disable/enable the default scale
>>
>> > -----Original Message-----
>> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>> > Moritz Barsnick
>> > Sent: Tuesday, February 11, 2020 19:04
>> > To: FFmpeg development discussions and patches <ffmpeg-
>> > devel at ffmpeg.org>
>> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add
>> > -autoscale
>> > to disable/enable the default scale
>> >
>> > On Mon, Feb 10, 2020 at 17:27:03 +0800, Linjie Fu wrote:
>> > > +    { "autoscale",        HAS_ARG | OPT_BOOL | OPT_SPEC |
>> > > +                          OPT_EXPERT | OPT_OUTPUT,
>> > >            { .off =
>> > OFFSET(autoscale) },
>> > > +        "automatically insert a scale filter at the end of the filter
>> > > graph if a
>> > resolution"
>> > > +        "change is detected. This ensures all frames are the same
>> > > resolution
>> > as the first frame"
>> > > +        "when they leave the filter chain (this option is enabled by
>> default)."
>> > > +        "If disabled, some encoders/muxers may not support this
>> > > mode."},
>> >
>> > Have you checked the output of "ffmpeg -h"? Your C strings merge
>> > directly together, and are therefore missing spaces, e.g. in
>> > "resolutionchange" and "as the first framewhen they leave",
>> >
>> Yes, spaces should be added, thanks for pointing this out :).
>>
>> I'll fix this in next version together with other suggestions if there is
>> any.
>>
> Ping, any suggestions?

Send updated patch with spaces fixed.

>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".